fix(NODE-4262): make startSession work without a connection#3286
fix(NODE-4262): make startSession work without a connection#3286baileympearson merged 9 commits intomainfrom
Conversation
08d6b88 to
b32a9d2
Compare
baileympearson
left a comment
There was a problem hiding this comment.
I think I commented all the places I found - but there are a number of tests that are refactored seemingly at random while other tests in the file are not, and a number of tests that are deleted.
Non-test changes look good to me - just some small questions and suggestions 😄
|
|
||
| test: async function () { | ||
| const session = client.startSession({ causalConsistency: true }); | ||
| collection.insertOne({ darmok: 'jalad' }, { session }); |
There was a problem hiding this comment.
unrelated to your work but we should await these functions - especially since they're examples!!
There was a problem hiding this comment.
I'm not so sure, we should look closer at this test, currently it will always pass
There was a problem hiding this comment.
This is in the examples folder, so I assumed it's an example that the docs team pulls in?
d820581 to
9f011bc
Compare
|
Test changes summary:
|
baileympearson
left a comment
There was a problem hiding this comment.
Assuming CI passes (it did last time), LGTM
Description
What is changing?
What is the motivation for this change?
Now that connect is automatic and since server sessions are created lazily we can allow the API to make sessions before the client has been connected.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>